Gracefully shut down server on "end" stdin #3430
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks like this breaks our CI. Any ideas why? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. The conversation will be locked in 7 days unless the pull request is reopened. Thank you for your contribution. |
This is referencing issue #1753 - where
react-scripts startwasn't closing upon stdin "end". I simply added one more condition on top of #2246 that would handle the "end" case and kill the process.I am integrating CRA with an elixir-phoenix app and when using
react-scripts startfrom within another process, it wasn't getting closed out when killing the main process. This made it difficult having tolsof -i $PORTandkill <pid>every time I had to restart the server.